ENH: Read from compressed data sources #11677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,18 +234,28 @@ class ParserWarning(Warning): | |||
| fields if it is not spaces (e.g., '~'). | |||
| """ % (_parser_params % _fwf_widths) | |||
|
|
|||
| def get_compression(filepath_or_buffer, encoding, compression_kwd): | |||
| """ | |||
| Determine the compression type of a file or buffer. | |||
There was a problem hiding this comment.
move this entire function to pandas.io.common; call it maybe get_compression_type.
This should be a bit more lightweight as you can see there are already other functions which use the compression. This will simply infer from a keywork and/or file extension and return the type of compression. Which can then be passed to other routines.
jreback
added
Enhancement
IO Data
| @@ -31,7 +31,7 @@ New features | |||
| Other enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
|
|
|||
| - `read_pickle` can now unpickle from compressed files (:issue:`<num>`). | |||
There was a problem hiding this comment.
add in the actual number here (11666)
|
needs some tests |
|
can you add some tests and upate |
|
@khs26 can you update |
1 similar comment
|
@khs26 can you update |
|
closing but pls reopen if you wish to continue working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of an effort to address compression in
read_*methods (at the moment, justread_pickle, as per #11666. So far, I've factored out the compression handling in the_readfunction ofpandas.io.parsersand used that in the pickling read routine.Tests on the way, along with actual testing that it works, docs and (if we want), I can also put something similar in the other
read_*methods too.